[Spice-devel] [PATCH 0/5] move vio-serial use to vdagent, remove named pipe

Alon Levy alevy at redhat.com
Wed Nov 7 10:14:26 PST 2012


> -move virtio-serial use from vdservice to vdagent
> -remove named pipe between vdservice & vdagent
> 
> pros:
> -make agent independent so it can run seperately without service
>  (e.g. single user, testing)
> -simplify service to just a launcher of agents
> -performance - data is currently copied on pipe read/write
> -separation between user sessions, no communication with service
> -easier to debug
> 
> cons:
> -when switching between users client will switch to server mode for a
> few ms

hmm, we can add another separate virtio device just for the purpose of saying "guest is agent aware", and have that opened (and nothing written to it) by the service. com.redhat.spice.alive

> 
> Arnon Gilboa (5):
>   vdservice: remove virtio-serial & pipe usage
>   vdagent: mv vdi_port files from vdservice
>   vdagent: use virtio-serial, remove pipe usage
>   vdagent: remove pipe common defs
>   vdagent: extract event_dispatcher from input_desktop_message_loop
> 
>  common/vdcommon.h             |   31 ---
>  vdagent/pci_vdi_port.cpp      |  132 +++++++++++
>  vdagent/pci_vdi_port.h        |   59 +++++
>  vdagent/vdagent.cpp           |  498
>  ++++++++++++++++++++---------------------
>  vdagent/vdagent.vcproj        |   32 +++-
>  vdagent/vdi_port.cpp          |   90 ++++++++
>  vdagent/vdi_port.h            |   75 ++++++
>  vdagent/virtio_vdi_port.cpp   |  187 +++++++++++++++
>  vdagent/virtio_vdi_port.h     |   33 +++
>  vdservice/pci_vdi_port.cpp    |  132 -----------
>  vdservice/pci_vdi_port.h      |   59 -----
>  vdservice/vdi_port.cpp        |   90 --------
>  vdservice/vdi_port.h          |   75 ------
>  vdservice/vdservice.cpp       |  471
>  +++-----------------------------------
>  vdservice/vdservice.vcproj    |   24 --
>  vdservice/virtio_vdi_port.cpp |  187 ---------------
>  vdservice/virtio_vdi_port.h   |   33 ---
>  17 files changed, 887 insertions(+), 1321 deletions(-)
>  create mode 100644 vdagent/pci_vdi_port.cpp
>  create mode 100644 vdagent/pci_vdi_port.h
>  create mode 100644 vdagent/vdi_port.cpp
>  create mode 100644 vdagent/vdi_port.h
>  create mode 100644 vdagent/virtio_vdi_port.cpp
>  create mode 100644 vdagent/virtio_vdi_port.h
>  delete mode 100644 vdservice/pci_vdi_port.cpp
>  delete mode 100644 vdservice/pci_vdi_port.h
>  delete mode 100644 vdservice/vdi_port.cpp
>  delete mode 100644 vdservice/vdi_port.h
>  delete mode 100644 vdservice/virtio_vdi_port.cpp
>  delete mode 100644 vdservice/virtio_vdi_port.h
> 
> --
> 1.7.4.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
> 


More information about the Spice-devel mailing list