[Spice-devel] [PATCH spice-protocol V2] vd_agent.h: drag-and-drop support

Marc-André Lureau mlureau at redhat.com
Fri Nov 23 04:10:06 PST 2012


Hi

----- Mensaje original -----
> Hi Marc-André,
> 
> On 11/23/2012 12:53 PM, Marc-André Lureau wrote:
> > Hi
> >
> 
> <snip>
> 
> >>
> >> +enum {
> >> +    VD_AGENT_FILE_XFER_RESULT_SUCCESS,
> >
> > What does success indicates? When is it sent?
> 
> I believe that Dunrong Huang based this second version on my protocol
> proposal,
> which answers this and a few of your other questions, see this mail:
> http://lists.freedesktop.org/archives/spice-devel/2012-November/011485.html

Ok, may I suggest XFER_STATUS_CAN_SEND_DATA ?

> > Instead of those fields that will be hard to extend and that mostly
> > only concern the guest agent, I would consider a key-value text
> > such as:
> >
> > [vdagent-file-xfer]
> > type=regular
> > mime=text/plain
> > name=foo.sh
> > time-modified=1353085649
> > time-...
> > can-read=true
> > can-execute=true
> > can-write=false
> > size=25
> I like, may I suggest we use this to implement this:
> http://ndevilla.free.fr/iniparser/

I would go for glib keyfile. But if we still have reasons to avoid glib usage, sure.

cheers


More information about the Spice-devel mailing list