[Spice-devel] [PATCH vdagent-linux] randr: do not set crtc mode to NULL when changing resolution

Marc-André Lureau marcandre.lureau at gmail.com
Fri Nov 23 11:15:05 PST 2012


Verified that with your patch things still work as expected.

The minor issue remaining is that when switching users, the client window
get resized for a brief moment to previous resolution before the agent
actually adjust to current window resolution, and then the client window is
restored.

This is not something we can solve easily at the agent level I am afraid,
but something to add to our TODO list.

Ack both patches for upstream?


On Thu, Nov 22, 2012 at 5:29 PM, Hans de Goede <hdegoede at redhat.com> wrote:

> Hi,
>
>
> On 11/22/2012 05:07 PM, Marc-André Lureau wrote:
>
>> Note with this patch, the previous patch is unnecessary: the
>> configuration can be sent to all agents (gdm & user) the creation/deletion
>> races will be ignored.
>>
>
> Cool, good way to test the race robustness of the code. Still I think it
> would be better to just not race at all, I know that cannot be completely
> avoided. But lets at least fix the agents racing amongst themselves. The
> attached patch  (untested)
>
> Regards,
>
> Hans
>



-- 
Marc-André Lureau
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20121123/da1c0108/attachment.html>


More information about the Spice-devel mailing list