[Spice-devel] server RFC: 2 significant build-time changes

[Hans de Goede]

Hi,

On 11/29/2012 11:25 AM, Christophe Fergeau wrote:
> Hi,
>
> On Wed, Nov 28, 2012 at 08:45:42PM +0100, Hans de Goede wrote:
>> On Fri, Nov 23, 2012 at 04:58:23PM +0100, Christophe Fergeau wrote:
>>> This patch series introduces 2 build system changes that are worth some
>>> attention. The first one disables client build by default as it's deprecated,
>>> and the second patch adds a dependency on glib2. Both of these patches
>>> are steps in the right direction in my opinion, but I'm happy with
>>> dropping them if there is some disagreement over that ;)
>>>
>>> The third patch uses the glib string API in a very specific place, there
>>> are probably cleanup that can be done in many places by replacing
>>> home-grown stuff with glib replacements. I also was not sure where
>>> to add the glib dep, it may be more appropriate to have it in spice-common
>>> so that we can use it in common/mem.[ch] for example.
>>
>> +1 for both changes.
>
> Everyone seems of favour of this change, I'll push it sometimes next week.
> Hans, does
> http://lists.freedesktop.org/archives/spice-devel/2012-November/011598.html
> address the concerns you had with
> http://lists.freedesktop.org/archives/spice-devel/2012-November/011585.html
> ?

Yes, the new version is fine!

Regards,

Hans