[Spice-devel] Fwd: Re: virt-viewer 0.5.4 crashes on debian wheezy

[Dominique Rodrigues]

-------- Original Message --------
Subject: Re: [Spice-devel] virt-viewer 0.5.4 crashes on debian wheezy
Date: Tue, 2 Oct 2012 11:41:00 +0200
From: Christophe Fergeau <cfergeau at redhat.com>
To: Dominique Rodrigues <dominique.rodrigues at nanocloud.com>

Hi,

On Tue, Sep 25, 2012 at 02:48:32AM +0200, Dominique Rodrigues wrote:
> Here are some informations.
[...snip]
> 
> 
> With Valgrind :
> 
> dominique at nanoClouD:~/VM/KVM$ valgrind remote-viewer
spice://localhost:7177
> 
> ==7146== Invalid free() / delete / delete[] / realloc()
> ==7146==    at 0x4C27D4E: free (vg_replace_malloc.c:427)
> ==7146==    by 0x41D4CE: virt_viewer_session_spice_main_channel_event
> (virt-viewer-session-spice.c:352)
> ==7146==    by 0xA2FD058: g_cclosure_marshal_VOID__ENUMv (in
> /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.3200.3)
> ==7146==    by 0xA2FAA02: ??? (in
> /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.3200.3)
> ==7146==    by 0xA313075: g_signal_emit_valist (in
> /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.3200.3)
> ==7146==    by 0xA3138C1: g_signal_emit (in
> /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.3200.3)
> ==7146==    by 0x69D3466: do_emit_main_context (in
> /usr/local/lib/libspice-client-glib-2.0.so.8.0.0)
> ==7146==    by 0x69DA07F: emit_main_context (in
> /usr/local/lib/libspice-client-glib-2.0.so.8.0.0)
> ==7146==    by 0xA583204: g_main_context_dispatch (in
> /lib/x86_64-linux-gnu/libglib-2.0.so.0.3200.3)
> ==7146==    by 0xA583537: ??? (in
> /lib/x86_64-linux-gnu/libglib-2.0.so.0.3200.3)
> ==7146==    by 0xA583931: g_main_loop_run (in
> /lib/x86_64-linux-gnu/libglib-2.0.so.0.3200.3)
> ==7146==    by 0x64AF2D4: gtk_main (in
> /usr/lib/x86_64-linux-gnu/libgtk-3.so.0.400.2)
> ==7146==  Address 0x1c730ab0 is 0 bytes inside a block of size 10 free'd
> ==7146==    at 0x4C27D4E: free (vg_replace_malloc.c:427)
> ==7146==    by 0x41D3E6: virt_viewer_session_spice_main_channel_event
> (virt-viewer-session-spice.c:329)
> ==7146==    by 0xA2FD058: g_cclosure_marshal_VOID__ENUMv (in
> /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.3200.3)
> ==7146==    by 0xA2FAA02: ??? (in
> /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.3200.3)
> ==7146==    by 0xA313075: g_signal_emit_valist (in
> /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.3200.3)
> ==7146==    by 0xA3138C1: g_signal_emit (in
> /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.3200.3)
> ==7146==    by 0x69D3466: do_emit_main_context (in
> /usr/local/lib/libspice-client-glib-2.0.so.8.0.0)
> ==7146==    by 0x69DA07F: emit_main_context (in
> /usr/local/lib/libspice-client-glib-2.0.so.8.0.0)
> ==7146==    by 0xA583204: g_main_context_dispatch (in
> /lib/x86_64-linux-gnu/libglib-2.0.so.0.3200.3)
> ==7146==    by 0xA583537: ??? (in
> /lib/x86_64-linux-gnu/libglib-2.0.so.0.3200.3)
> ==7146==    by 0xA583931: g_main_loop_run (in
> /lib/x86_64-linux-gnu/libglib-2.0.so.0.3200.3)
> ==7146==    by 0x64AF2D4: gtk_main (in
> /usr/lib/x86_64-linux-gnu/libgtk-3.so.0.400.2)


This is a double-free I introduced in virt-viewer 0.5.4 :( This only shows
up when the SPICE connection needs a password and is fixed by
http://git.fedorahosted.org/cgit/virt-viewer.git/commit/?id=a4e588e3eacf4e5590ff98171a495f8fa0e37375

NB (for future bugs ;): installing glib, spice-gtk and gtk+ debug symbols
would make the
backtrace much nicer to read.


Thanks for the report,

Christophe

--