[Spice-devel] [qxl-win] miniport: QXLEscape: use 5/5/5 16 bit

[Christophe Fergeau]

Looks good to me, ACK from me (but you might want to wait for someone more
knowledgeable about this to look at it ;)

Christophe

On Wed, Oct 10, 2012 at 04:21:53PM +0200, Alon Levy wrote:
> Change IOCTL_QXL_SET_CUSTOM_DISPLAY to use 5/6/5 (via SetCustomDisplay).
> 
> The replaced 5/6/5 is not supported by us. Specifically we fail
> display/rop.c:TestSrcBits and thus fail _BitBlt. I'm not sure how
> exactly this causes the BSOD for 863410, but it does in fact do that,
> and applying this fix, by not failing _BitBlt also fixes 863410.
> 
> RHBZ: 863410
> ---
>  miniport/qxl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/miniport/qxl.c b/miniport/qxl.c
> index bd449c3..55e55d3 100644
> --- a/miniport/qxl.c
> +++ b/miniport/qxl.c
> @@ -494,7 +494,7 @@ VP_STATUS FillVidModeInfo(VIDEO_MODE_INFORMATION *pMode, ULONG xres, ULONG yres,
>      switch (bpp)
>      {
>          case 16:
> -            FillVidModeBPP(pMode, 5, 6, 5, 0xF800, 0x7E0, 0x1F);
> +            FillVidModeBPP(pMode, 5, 5, 5, 0x7C00, 0x3E0, 0x1F);
>              break;
>          case 24:
>          case 32:
> -- 
> 1.7.12.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20121011/56416a1c/attachment.pgp>