[Spice-devel] [PATCH spice-gtk] channel: improve debugging message

Hans de Goede hdegoede at redhat.com
Thu Oct 18 06:41:00 PDT 2012


ACK.

On 10/18/2012 03:22 PM, Marc-André Lureau wrote:
> The open_host() can return FALSE when the connection is discarded or
> skipped. Improve the message to not indicate a failure.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=858232
> ---
>   gtk/spice-channel.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gtk/spice-channel.c b/gtk/spice-channel.c
> index c5e8d9f..fea46d7 100644
> --- a/gtk/spice-channel.c
> +++ b/gtk/spice-channel.c
> @@ -2119,7 +2119,7 @@ reconnect:
>       c->sock = spice_session_channel_open_host(c->session, channel, c->tls);
>       if (c->sock == NULL) {
>           if (!c->tls) {
> -            CHANNEL_DEBUG(channel, "connection failed, trying with TLS port");
> +            CHANNEL_DEBUG(channel, "trying with TLS port");
>               c->tls = true; /* FIXME: does that really work with provided fd */
>               goto reconnect;
>           } else {
>


More information about the Spice-devel mailing list