[Spice-devel] [PATCH spice-gtk 6/6] spice-session: make spice_session_channel_open_host() async again

[Christophe Fergeau]

On Thu, Oct 18, 2012 at 06:11:58PM +0200, Marc-André Lureau wrote:
> On Thu, Oct 18, 2012 at 6:08 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> > On Fri, Aug 24, 2012 at 03:58:19PM +0200, Marc-André Lureau wrote:
> >> The previous patches (introducing GSocketClient & GProxy usage) turned
> >> the code into only sync calls.
> >
> > This would be much nicer to review if the GProxy changes were done
> > separately I think, or folded into patch 4/6
> >
> 
> Can you be more precise? from a quick glance, I failed to see what you
> are talking about, but I have not looked at the code for a long time.
> You probably have it in mind more than me :)

4/6 adds the http://hostname:port parsing to spice-session.c, 5/6
introduces SpiceProxy which contains this parsing code as well, 6/6
switches spice-session.c to using SpiceProxy and also makes things async.

It would be nicer to add SpiceProxy, then make spice-session.c handle proxy
synchronously using SpiceProxy, and then making things async.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20121018/bb752a7f/attachment.pgp>