[Spice-devel] [PATCH spice-gtk] Fix disabling mouse acceleration on X11

[Christophe Fergeau]

On Fri, Oct 19, 2012 at 11:49:51AM +0200, Hans de Goede wrote:
> Hi,
> 
> On 10/18/2012 08:45 PM, Marc-André Lureau wrote:
> >It turns out the acceleration code didn't work, because we didn't set
> >it to the default values. Then we need to restore it back. Eventually,
> >it would be nicer to inhibit gnome-settings-daemon to apply devices
> >ghanges, and restore settings when un-inhibiting.
> 
> Hmm, interesting. I'm pretty sure I tested the original patch, and back
> in the days I tested it, it worked as advertised. But maybe a newer version
> of Xorg has changed its behavior. Or maybe my testing was wrong...
> 
> From the XChangePointerControl man-page:
> 
>        do_accel  Specifies a Boolean value that controls whether the values
>                  for the accel_numerator or accel_denominator are used.
> 
>        do_threshold
>                  Specifies a Boolean value that controls whether the value for
>                  the threshold is used.
> 
> I interpreted setting these 2 to false as meaning disable accel, but one
> could argue they mean don't change accel / threshold, which is an interpretation
> which would explain your patch.

This is what the manpage is saying a bit further down:

"The values of the do_accel and do_threshold arguments must be True for the
pointer values to be set, or the parameters are unchanged."

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20121019/6ec45352/attachment.pgp>