[Spice-devel] [PATCH spice-html5] rewrite quic.js to be a native javascript implementation

Alon Levy alevy at redhat.com
Thu Sep 13 08:07:29 PDT 2012


> humm, I thought I fixed this issue. I am using thunderbird sending as
> text with line wrapping turned off.
> 
> I will keep tweaking and see if i can fully resolve this for my next
> patches.
> 
> They should be shorter so easier for me to really make sure the
> e-mail is not corrupting them.

If you can perhaps attach this patch (just this once :) it might be simpler. Since I've already spent too much time trying to fix the patch to apply (currently stuck at 
patching file TODO
patching file display.js
patching file makequic
patching file quic.c
patching file quic.js
patch: **** malformed patch at line 35649:  
)
> 
> -aric
> 
> On 9/13/12 9:58 AM, Alon Levy wrote:
> >> Alon Levy píše v Čt 13. 09. 2012 v 10:31 -0400:
> >>>> On Wed, Sep 12, 2012 at 11:22:14AM -0500, Aric Stewart wrote:
> >>>>> there remain a few TODOs including implementing more than just
> >>>>> rgb32 images
> >>>>>
> >>>>> Signed-off-by: Aric Stewart <aric at codeweavers.com>
> >>>> [cut to avoid bombarding the list]
> >>>>
> >>>> I can't actually review this, although it seems like a great
> >>>> deal
> >>>> of
> >>>> progress. Should I wait for an ack by Jeremy or just push it?
> >>>
> >>> Got Jeremy's ACK, trying to apply, but there are a number of
> >>> problems:
> >>>   wrong EOL on one line.
> >>
> >> If you're using evolution or similar client with "formatting" of
> >> plain
> >> text, switch the patch formatting of the patch to "preformatted"
> >> to
> >> avoid automagic line breaks.
> > 
> > I'm using mutt. The problem is not in mutt, it's the patch - it's
> > already got broken lines. Search for ,0x80,0x08,0xD8,0x91,0x80,0x
> > 
> >>
> >> David
> >>
> >>>   multiple places where a long line was broken by your email
> >>>   agent
> >>>   corrupting the patch (line not starting with - that isn't part
> >>>   of
> >>>   the context).
> >>>
> >>> I'm fixing it by hand, just noting for later.
> >>>
> >>>>
> >>>> Alon
> >>>> _______________________________________________
> >>>> Spice-devel mailing list
> >>>> Spice-devel at lists.freedesktop.org
> >>>> http://lists.freedesktop.org/mailman/listinfo/spice-devel
> >>>>
> >>> _______________________________________________
> >>> Spice-devel mailing list
> >>> Spice-devel at lists.freedesktop.org
> >>> http://lists.freedesktop.org/mailman/listinfo/spice-devel
> >>
> >> --
> >>
> >> David Jaša, RHCE
> >>
> >> SPICE QE based in Brno
> >> GPG Key:     22C33E24
> >> Fingerprint: 513A 060B D1B4 2A72 7F0D 0278 B125 CD00 22C3 3E24
> >>
> >>
> >>
> >> _______________________________________________
> >> Spice-devel mailing list
> >> Spice-devel at lists.freedesktop.org
> >> http://lists.freedesktop.org/mailman/listinfo/spice-devel
> >>
> 


More information about the Spice-devel mailing list