[Spice-devel] [spice-common] Fix type of SpiceCursorHeader::type

Christophe Fergeau cfergeau at redhat.com
Thu Sep 20 07:30:15 PDT 2012


On Wed, Sep 19, 2012 at 05:23:44PM +0300, Uri Lublin wrote:
> On 09/13/2012 06:53 PM, Christophe Fergeau wrote:
> >In spice.proto it's defined as enum8 cursor_type type;, which means
> >it's demarshalled as an uint8_t.
> >This caused valgrind warnings about using uninitialized memory
> >during a connection to a VM with remote-viewer
> Hi Christophe,
> 
> Your patch looks good to me.
> But note that in spice1.proto cursor_type is enum16.
> It seems spice1.proto is only used by spice-client

Hmm good point, maybe this patch should be reverted then... I always get
confused with spice.proto VS spice1.proto

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20120920/0c406444/attachment.pgp>


More information about the Spice-devel mailing list