[Spice-devel] [PATCH spice-gtk] spice-pulse: Fix set_sink_input_volume() failed on seamless migration

[Hans de Goede]

Hi,

On 04/01/2013 07:58 PM, Marc-André Lureau wrote:
>
>
> ----- Mensaje original -----
>> On seamless migration "switch-over" the playback_volume_changed callback gets
>> called, and at this time the channel object's nchannels property is 0,
>> leading to a warning like this:
>>
>> (remote-viewer:8726): GSpice-WARNING **: set_sink_input_volume() failed:
>> Invalid argument
>>
>> This patch fixes this.
>
> Why is that? the nchannels property is set when receiving volume. Why does the server send a volume with 0 channels? Does that make sense? Shouldn't the fix be in the server instead?

A very valid question I tracked this down to a server bug, for which I
just send a patch.

Still I would like to push the trivial spice-gtk fix to silence the warning
upstream so, so as to silence it when using a new spice-gtk with an older
spice-server.

Regards,

Hams