[Spice-devel] [PATCH spice-gtk] spice-pulse: Fix set_sink_input_volume() failed on seamless migration

[Hans de Goede]

Hi,

On 04/01/2013 11:11 PM, Marc-André Lureau wrote:
> Hi
>

<snip>

>> I think we can agree that we should *never* deliberately call functions with
>> invalid parameters. So we need to *explicitly* check for nchannels == 0,
>> rather
>> then relying on pa_context_set_sink_input_volume to check this for us.
>
> I agree, but keep a warning, a return_if_fail() would do too, in channel-playback.c / channel-record.c

Ok, one new patch implementing this coming up.

Regards,

Hans