[Spice-devel] [spice-gtk] build: fix parallel install

Christophe Fergeau cfergeau at redhat.com
Wed Apr 10 07:58:05 PDT 2013


From: Tiziano Müller <tiziano.mueller at stepping-stone.ch>

This is a workaround for broken parallel install support in automake
with LTLIBRARIES, see http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7328

Broken parallel install can be reproduced when building with --with-gtk=2.0
and dies with:
/home/teuf/redhat/spice-gtk/gtk/.libs/libspice-client-gtk-2.0.so: file not recognized: File truncated
collect2: error: ld returned 1 exit status
libtool: install: error: relink `SpiceClientGtk.la' with the above command before installing it
make[5]: *** [install-pyexecLTLIBRARIES] Erreur 1
m
---

Hey, this patch has been pending for a very long while.
I've finally managed to find how to reproduce this parallel build issue (building with --with-gtk=2.0)
and to confirm it makes these build issues go away, so I'd like to push this, any objections?

Christophe

 gtk/Makefile.am | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/gtk/Makefile.am b/gtk/Makefile.am
index eb64b13..3c6d3e6 100644
--- a/gtk/Makefile.am
+++ b/gtk/Makefile.am
@@ -546,6 +546,11 @@ vncdisplaykeymap_win322xtkbd.c:
 if WITH_PYTHON
 pyexec_LTLIBRARIES = SpiceClientGtk.la
 
+# workaround for broken parallel install support in automake with LTLIBRARIES
+# http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7328
+install_pyexecLTLIBRARIES = install-pyexecLTLIBRARIES
+$(install_pyexecLTLIBRARIES): install-libLTLIBRARIES
+
 SpiceClientGtk_la_LIBADD = libspice-client-gtk-2.0.la libspice-client-glib-2.0.la $(PYGTK_LIBS)
 SpiceClientGtk_la_CFLAGS = $(GTK_CFLAGS) $(PYTHON_INCLUDES) $(PYGTK_CFLAGS) $(WARN_PYFLAGS)
 SpiceClientGtk_la_LDFLAGS = -module -avoid-version -fPIC
-- 
1.8.1.4



More information about the Spice-devel mailing list