[Spice-devel] [PATCH vdagent-win] vdagent: enable disabled monitor with default resolution

[agilboa at redhat.com]

On 04/18/2013 09:30 PM, Christophe Fergeau wrote:
> Hey Arnon,
>
> On Thu, Apr 18, 2013 at 08:58:30PM +0300, Arnon Gilboa wrote:
>> When enabling a disabled monitor, init_dev_mod() "failed to create DC",
>> and therefore due to the custom resolution received, in set_displays()
>> "No suitable mode found for display".
> Looking at init_dev_mode(), I don't really think this is related to the
> custom resolution. If I'm reading init_dev_mode() properly, the "failed to
> create DC" error is returned before trying to use the custom resolution. My
> guess would be that this function fails because the monitor is
> disabled/turned off.
sure, but when it's disabled -> you fail to create a DC -> cannot set a 
custom resolution when you enable it.
however, we can patch it as 2-phase: (1) enable with default resolution 
(2) set custom resolution .

> This patch is pointing at the part of the code that is problematic, but it
> looks like it's papering over the real issue.
>
> Christophe