[Spice-devel] [PATCH win-agent] Try harder to enable monitors

[Christophe Fergeau]

On Mon, Apr 22, 2013 at 11:08:30PM +0200, Marc-André Lureau wrote:
> 0ba6e2936 was trying to fix CreateDC() failing when the monitor is
> disabled, unfortunately, enabling monitor with an arbitrary resolution
> may still fail (the previous resolution, or the current one).
> 
> This patch address the issue by first trying the current resolution, and
> falling back to a well-known resolution. This causes a temporary client
> resolution change (bad), which is immediately adjusted to the arbitrary
> resolution.
> 
> We may want to improve agent->driver communication of arbitrary
> resolution before the driver is loaded, perhaps using registry or via
> the spice server. Any of these solution will unfortunately take some more
> time which we are missing.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=922394
> 
> (seem to solve related bugs, like mouse offset, or flashing monitors)
> ---
>  vdagent/desktop_layout.cpp | 35 ++++++++++++++++++++++++++---------
>  1 file changed, 26 insertions(+), 9 deletions(-)
> 
> diff --git a/vdagent/desktop_layout.cpp b/vdagent/desktop_layout.cpp
> index bce9ac0..c474edb 100644
> --- a/vdagent/desktop_layout.cpp
> +++ b/vdagent/desktop_layout.cpp
> @@ -253,19 +253,36 @@ bool DesktopLayout::init_dev_mode(LPCTSTR dev_name, DEVMODE* dev_mode, DisplayMo
>          return true;
>      }
>  
> -    // attach
> -    EnumDisplaySettings(dev_name, ENUM_CURRENT_SETTINGS, dev_mode);
> -    ret = ChangeDisplaySettingsEx(dev_name, dev_mode, NULL, CDS_UPDATEREGISTRY, NULL);
> -    vd_printf("attach %d", ret);
> -
> -    // Update custom resolution
> -    custom.xres = mode->_width;
> -    custom.yres = mode->_height;
> -    custom.bpp = mode->_depth;
>      hdc = CreateDC(dev_name, NULL, NULL, NULL);
>      if (!hdc) {
> +        // for some reason, windows want those 3 flags to enable monitor
> +        dev_mode->dmFields = DM_PELSWIDTH | DM_PELSHEIGHT | DM_POSITION;
> +        dev_mode->dmPelsWidth = mode->_width;
> +        dev_mode->dmPelsHeight = mode->_height;
> +        ret = ChangeDisplaySettingsEx(dev_name, dev_mode, NULL, CDS_UPDATEREGISTRY, NULL);

Isn't it possible to do that where the "attach" was before in case the
screen is off? If we know the screen is off, there is not much point in
trying the CreateDC as this will fail.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20130423/6be93442/attachment-0001.pgp>