[Spice-devel] [PATCH v3 01/10] red_worker: mark DRAW_ALL as broken

[Alon Levy]

> On Tue, Aug 13, 2013 at 08:50:50AM -0400, Alon Levy wrote:
> > > On Tue, Aug 13, 2013 at 10:47:20AM +0300, Alon Levy wrote:
> > > > ---
> > > >  server/red_worker.c | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > > 
> > > > diff --git a/server/red_worker.c b/server/red_worker.c
> > > > index 9896696..08e2a43 100644
> > > > --- a/server/red_worker.c
> > > > +++ b/server/red_worker.c
> > > > @@ -87,6 +87,7 @@
> > > >  //#define DUMP_BITMAP
> > > >  //#define PIPE_DEBUG
> > > >  //#define RED_WORKER_STAT
> > > > +/* TODO: DRAW_ALL is broken. */
> > > 
> > > Can you be more specific about what 'broken' means? Or do you just know
> > > it
> > > is broken but don't know what happens when trying to use it?
> > 
> > Rendering is incorrect when using off screen surfaces. It may be easy to
> > solve, I'm not sure, I just wanted to mark that if you unset that macro
> > variable you will get incorrect rendering.
> 
> I meant, can you be more specific in that code comment? just mentioning
> 'rendering' in the comment would be enough I guess.

OK, I'll do that. If there are no further comments until the end of today I'll push with this fix instead of bombarding the list again.

> 
> Christophe
>