[Spice-devel] [PATCH spice-gtk] glib-compat: g_slist_free_full: pass the right ptr to destroy (rhbz#997893)

Uri Lublin uril at redhat.com
Mon Aug 19 08:07:42 PDT 2013


On 08/19/2013 05:53 PM, Hans de Goede wrote:
> The destroy function passed to g_slist_free_full should be passed the elements
> data pointer, not the element itself.
>
> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
> ---
>   gtk/glib-compat.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gtk/glib-compat.c b/gtk/glib-compat.c
> index 21be1f6..c3bb8e6 100644
> --- a/gtk/glib-compat.c
> +++ b/gtk/glib-compat.c
> @@ -88,7 +88,7 @@ g_slist_free_full(GSList         *list,
>   
>       if (free_func) {
>           for (el = list; el ; el = g_slist_next(el)) {
> -            free_func(el);
> +            free_func(el->data);
>           }
>       }
>   

Ack.



More information about the Spice-devel mailing list