[Spice-devel] [PATCH] miniport/qxl.inf: simplify by having FeatureScore for everyone

[Alon Levy]

> Hi,
> 
> I don't know much about the inf file, but the patch looks ok, as long as
> the FeatureScore is ignored on WindowsXp.

OK, thanks for the review. It does get ignored on XP per my testing.

> However, how does this patch
> fix 728259?  IIUC 728259 should be fixed by generating different inf
> file for different operating systems.

You are absolutely right, I'll remove the RHBZ from the comment. I found this patch on my branch called 728259 and I wasn't sure why it was missing the RHBZ line, so I just added it.

The actual patch to fix 728259 does just what you said, but because generation of the inf files is not done in this repository there is no patch to send for it.

> Also, why does "FeatureScore = FC" ?

It's on MSDN somewhere, I can't find it right now, I will and make a note in the comment.

> 
> Best,
> Yonit.
> On 08/20/2013 09:37 AM, Alon Levy wrote:
> > FeatureScore is the only difference between the _vista options and the
> > rest, so just setting it also for windows xp using drivers results in a
> > simplification of the inf file, and no downside.
> >
> > RHBZ: 728259
> > ---
> >   xddm/miniport/qxl.inf | 22 ++--------------------
> >   1 file changed, 2 insertions(+), 20 deletions(-)
> >
> > diff --git a/xddm/miniport/qxl.inf b/xddm/miniport/qxl.inf
> > index dbd11dd..f3bbb86 100644
> > --- a/xddm/miniport/qxl.inf
> > +++ b/xddm/miniport/qxl.inf
> > @@ -17,30 +17,18 @@ qxl.Display = 11	; system32
> >   [Manufacturer]
> >   %RHAT% = q, NTx86, NTamd64, NTx86.6.0, NTamd64.6.0
> >
> > -; WinXP x86 and up
> > +; x86
> >   [q.NTx86]
> >   %RHAT% %QXL% = qxl, PCI\VEN_1b36&DEV_0100&SUBSYS_11001af4
> >
> > -; WinXP x64 and up
> > +; x64
> >   [q.NTamd64]
> >   %RHAT% %QXL% = qxl, PCI\VEN_1b36&DEV_0100&SUBSYS_11001af4
> >
> > -; Vista x86 and up
> > -[q.NTx86.6.0]
> > -%RHAT% %QXL% = qxl_vista, PCI\VEN_1b36&DEV_0100&SUBSYS_11001af4
> > -
> > -; Vista x64 and up
> > -[q.NTamd64.6.0]
> > -%RHAT% %QXL% = qxl_vista, PCI\VEN_1b36&DEV_0100&SUBSYS_11001af4
> > -
> > -
> >   [ControlFlags]
> >   ExcludeFromSelect = *
> >
> >   [qxl]
> > -CopyFiles = qxl.Miniport, qxl.Display
> > -
> > -[qxl_vista]
> >   FeatureScore = FC
> >   CopyFiles = qxl.Miniport, qxl.Display
> >
> > @@ -60,9 +48,6 @@ qxldd.dll = 1
> >   [qxl.SoftwareSettings]
> >   AddReg = qxl_SoftwareDeviceSettings
> >
> > -[qxl_vista.SoftwareSettings]
> > -AddReg = qxl_SoftwareDeviceSettings
> > -
> >   [qxl_SoftwareDeviceSettings]
> >   HKR,, InstalledDisplayDrivers,        %REG_MULTI_SZ%, qxldd
> >   HKR,, VgaCompatible,                  %REG_DWORD%,    0
> > @@ -74,9 +59,6 @@ HKR,, Acceleration.Level,             %REG_DWORD%,    0
> >   [qxl.Services]
> >   AddService = qxl, 0x00000002, qxl_Service_Inst ; Assign the named service
> >   as the PnP function driver
> >
> > -[qxl_vista.Services]
> > -AddService = qxl, 0x00000002, qxl_Service_Inst ; Assign the named service
> > as the PnP function driver
> > -
> >   [qxl_Service_Inst]
> >   ServiceType    = 1                  ; SERVICE_KERNEL_DRIVER
> >   StartType      = 3                  ; SERVICE_DEMAND_START
> >
> 
>