[Spice-devel] [PATCH] spice-common: remove version construction

[Michael Tokarev]

07.02.2013 21:02, Marc-André Lureau wrote:
> ----- Mensaje original -----
>> Version string isn't used anywhere in spice-common, and there's
>> no version for spice-common module per se, either.  Hoever,
>> configure.ac has this:
>>
>>   AC_INIT([spice-common],
>>           [m4_esyscmd(build-aux/git-version-gen .tarball-version)],
>>           [spice-devel at lists.freedesktop.org])
>>
>> But since git-version-gen script is not provided in spice-common
>> module, multiple error messages are produced when generating
>> configure (running autogen/autoreconf), like this:
>>
>>    sh: ./build-aux/git-version-gen: not found
>>
>> (repeated about 50 times).
>
> I suppose you are doing a autoreconf from a tarball directory.

Yes, after modifying ./configure.ac or some other files it is necessary.

> Hmm, what about spice-protocol? Do you also have the same warning?

spice-protocol has explicit version in configure.ac, like this:

  m4_define([SPICE_MAJOR], 0)
  m4_define([SPICE_MINOR], 12)
  m4_define([SPICE_MICRO], 2)
  AC_INIT(spice-protocol, [SPICE_MAJOR.SPICE_MINOR.SPICE_MICRO], [], spice-protocol)

> Shipping the git-version-gen is a solution too I suppose.

The thing is that this version string is not used anywhere
in spie-common.  Spice-common has no version number per se,
since it is not a separate/stand-alone project.

Thanks,

/mjt