[Spice-devel] [PATCH spice-protocol] vd_agent: Add a VD_AGENT_FILE_XFER_STATUS_SUCCESS result value

Hans de Goede hdegoede at redhat.com
Thu Feb 28 05:02:26 PST 2013


Currently the sender of a file xfer assumes success on having send the
last data bytes. But the transfer may still fail on the other side.

This commits adds a VD_AGENT_FILE_XFER_STATUS_SUCCESS result value instead.

Since we have not done an agent release with file-xfer support yet, the client
code can simply assume that it will always get *a* VD_AGENT_FILE_XFER_STATUS_
message for a transfer now. As for the existing spice-gtk release with
file-xfer support, if it talks to an agent sending this message, this will
trigger a g_return_if_fail, which is not really pretty, but has no negative
side-effects other then an error message being logged.

Signed-off-by: Hans de Goede <hdegoede at redhat.com>
---
 spice/vd_agent.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/spice/vd_agent.h b/spice/vd_agent.h
index b71f7d9..a150a6f 100644
--- a/spice/vd_agent.h
+++ b/spice/vd_agent.h
@@ -79,6 +79,7 @@ enum {
     VD_AGENT_FILE_XFER_STATUS_CAN_SEND_DATA,
     VD_AGENT_FILE_XFER_STATUS_CANCELLED,
     VD_AGENT_FILE_XFER_STATUS_ERROR,
+    VD_AGENT_FILE_XFER_STATUS_SUCCESS,
 };
 
 typedef struct SPICE_ATTR_PACKED VDAgentFileXferStatusMessage {
-- 
1.8.1.2



More information about the Spice-devel mailing list