[Spice-devel] [PATCH spice-gtk V5 0/3] simply implement of file transfer

Dunrong Huang riegamaths at gmail.com
Tue Jan 8 19:06:27 PST 2013


Marc-André: ping? Are you happy with these patches, can they be applied?

On Sat, Jan 5, 2013 at 6:59 PM, Dunrong Huang <riegamaths at gmail.com> wrote:
> These are the fifth version of patches which implement file transfer from
> client to guest.
>
> V4 -> V5:
>    * Only update first patch
>    * Imporve error report
>    * Add spice_main_file_copy_finish() function.
>    * Some code cleanup. (e.g. file_xfer_task_free())
>    * Limit spice_main_file_copy() to a single file.
>
> V3 -> V4:
>    * Address Marc-André's comments
>    * s/spice_main_file_xfer/spice_main_file_copy
>    * Use a new algorithm to send data, instead of g_idle_add().
>    * Use gio async API to open, read, query files
>
> V2 -> V3:
>    * s/drag-and-drop/file-xfer
>    * Use key-value text as data included in start message
>
> V1 -> V2:
>    * Address Marc-André and hans's comments, most of the code are rewritten.
>    * Move all file operation to the channel level
>    * Use glib API for file operations
>    * spice protocol related file transfer has been extended for the future's work
>    * Only export a single API spice_main_file_xfer()
>
> Dunrong Huang (3):
>   file-xfer: handling various transfer messages in main channel
>   file-xfer: handle "drag-data-received" signal
>   file-xfer: disable file-xfer when agent is not connected
>
>  gtk/channel-main.c      | 515 ++++++++++++++++++++++++++++++++++++++++++++++++
>  gtk/channel-main.h      |  12 ++
>  gtk/map-file            |   2 +
>  gtk/spice-glib-sym-file |   2 +
>  gtk/spice-widget.c      |  46 +++++
>  5 files changed, 577 insertions(+)
>
> --
> 1.8.0
>



-- 
Best Regards,

Dunrong Huang


More information about the Spice-devel mailing list