[Spice-devel] [PATCH spice-protocol] vd_agent.h: add a VD_AGENT_CAP_SPARSE_MONITORS_CONFIG capability (rhbz#881072)

Alon Levy alevy at redhat.com
Tue Jan 15 05:31:10 PST 2013


On Thu, Jan 10, 2013 at 11:52:28PM +0100, Hans de Goede wrote:
> Currently the agent expect a monitor config to be continuous. If the user has
> 3 monitors (3 spice display windows) open and tries to disable the 2nd one,
> then instead of the 2nd one being closed, the 3th one ends up closed.
> 
> To be able to fix this we need to be able to send a sparse monitor config
> to the agent. A monitor being disabled in such a sparse config is simply
> represented by its width and height being 0 in its VDAgentMonConfig.
> 
> Since old versions of the agent won't be capable of dealing with such a
> 0x0 sized monitor, this patch adds a new VD_AGENT_CAP_SPARSE_MONITORS_CONFIG
> capability to signal to the client that the agent understands this, and
> the client should only send sparse monitor configs to agents with this
> capability.

Sounds good to me,
ACK.

> 
> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
> ---
>  spice/vd_agent.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/spice/vd_agent.h b/spice/vd_agent.h
> index 2b9884e..8a9a242 100644
> --- a/spice/vd_agent.h
> +++ b/spice/vd_agent.h
> @@ -174,6 +174,7 @@ enum {
>      VD_AGENT_CAP_DISPLAY_CONFIG,
>      VD_AGENT_CAP_CLIPBOARD_BY_DEMAND,
>      VD_AGENT_CAP_CLIPBOARD_SELECTION,
> +    VD_AGENT_CAP_SPARSE_MONITORS_CONFIG,
>      VD_AGENT_END_CAP,
>  };
>  
> -- 
> 1.8.0.2
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel


More information about the Spice-devel mailing list