[Spice-devel] [xf86 qxl driver PATCH 0/5] qxl_driver: adjust monitors_config to memory remap

[Hans de Goede]

Hi,

As mentioned in 5/5 I agree we should add some sort of checksum mechanism
to the monitors_config, or change things so that it does not move around ...

But that is something for another series on top, so ACK series.

Regards,

Hans


On 01/17/2013 03:26 PM, Uri Lublin wrote:
> This patch-set fixes rhbz #883578 and also cleans up the code a bit.
>
> The problem is that after a memory-remap, qxl->monitors_config still
> points to the first/old location, which may be overlapping with
> video memory. That may cause bad monitors_config values to
> be read by the destination host and confuse both the server and
> the client.
>
>
> Uri Lublin (5):
>    qxl_driver: remove unused enum ROPDescriptor
>    qxl_pre_init: fix calculation of available video memory
>    qxl_driver: check_crtc: handle qxl->crtcs == NULL
>    qxl_driver: simplify calling qxl_update_monitors_config
>    qxl_driver: monitors_config: adjust to memory-remap
>
>   src/qxl_driver.c |   47 ++++++++++++++++++++---------------------------
>   1 files changed, 20 insertions(+), 27 deletions(-)
>
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>