[Spice-devel] [PATCH spice-html5] Add spice_auto.html for automated console display

Jeremy White jwhite at codeweavers.com
Mon Jan 21 12:13:15 PST 2013


On 01/15/2013 03:46 PM, Daniel P. Berrange wrote:
> On Tue, Jan 08, 2013 at 11:02:38AM -0600, Jeremy White wrote:
>> On 01/08/2013 03:44 AM, Daniel P. Berrange wrote:
>>> From: "Daniel P. Berrange" <berrange at redhat.com>
>>>
>>> Add a spice_auto.html which removes the form inputs and obtains
>>> connection details from query parameters. The optional 'token'
>>> parameter is an opaque string passed to the websockets server
>>> to allow it to auto-determine the correct console. Otherwise
>>> the host/port/password/etc can be provided explicitly.
>>>
>>> This is sufficient to integrate SPICE HTML5 with OpenStack
>>
>> Couldn't this all be done as an optional feature of spice.html?
>>
>> That is, auto detect the inbound parameters and switch the behavior of
>> the page?  It seems a shame to have two largely duplicate entry pages.
> 
> I didn't want it to fallback to displaying a form if someone
> forgot to provide the parameters. This is the same as done
> with noVNC

Alright, acked and pushed.

Cheers,

Jeremy


More information about the Spice-devel mailing list