[Spice-devel] [PATCH xf86-video-qxl 2/2] qxl: Don't add the current mode to the modelist as preferred-mode (rhbz#894421)

[Hans de Goede]

Hi,


On 01/24/2013 12:54 PM, Hans de Goede wrote:
> Adding the current mode to the monitor modelist as "extra" preferred
> mode means that each time the modelist gets queried, and the resolution
> has changed, a different modelist is returned for the output. A different
> modelist gets seen as a different monitor by gnome-settings-daemon, causing
> it to think that the monitor has been unplugged and replaced with another
> one and to re-do any auto-configuration for that monitor.
>
> This causes undesirable "funny" side-effects such as described in detail
> here: https://bugzilla.redhat.com/show_bug.cgi?id=894421#c7
>
> This patch fixes the "initial resolution too large" problem the adding
> of the current mode to the list was added for, by instead marking 1024x768,
> which is our default resolution, as preferred mode.
>
> Signed-off-by: Hans de Goede <hdegoede at redhat.com>

This is a minimal fix for 894421, which I intended to already send
yesterday (and I referred to in some other threads). Since we
will likely go with Jeremy's more complete
"Establish a preferred default of 1024x768 correctly."

Patch, this one is sort of obsolete, but I still wanted to send it
out here since I referred to it on other threads.

Regards,

Hans