[Spice-devel] [PATCH spice-gtk] Add SpiceSession:proxy

[Christophe Fergeau]

On Tue, Jan 29, 2013 at 02:12:57PM +0100, Christophe Fergeau wrote:
> On Tue, Jan 29, 2013 at 01:33:43PM +0100, Marc-André Lureau wrote:
> > @@ -118,24 +119,29 @@ enum {
> >  static guint signals[SPICE_SESSION_LAST_SIGNAL];
> >  
> >  
> > -static SpiceProxy* get_proxy(void)
> > +static void update_proxy(SpiceSession *self, const gchar *str)
> >  {
> > +    SpiceSessionPrivate *s = self->priv;
> > +    SpiceProxy *proxy = NULL;
> >      GError *error = NULL;
> > -    SpiceProxy *proxy;
> >  
> > -    const gchar *proxy_env = g_getenv("SPICE_PROXY");
> > -    if (proxy_env == NULL || strlen(proxy_env) == 0)
> > -        return NULL;
> > +    if (str == NULL)
> > +        str = g_getenv("SPICE_PROXY");
> > +    if (str == NULL || *str == 0)
> > +        return;
> 
> We need a g_clear_object(&s->proxy); or we won't be able to clear the
> proxy.

The patch seems to have been pushed without addressing this comment?

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20130129/5dc1746e/attachment.pgp>