[Spice-devel] [spice-gtk 2/5] session: Lookup URI query part before path part

Uri Lublin uril at redhat.com
Wed Jun 5 09:08:53 PDT 2013


On 06/05/2013 03:21 PM, Christophe Fergeau wrote:
> On Wed, Jun 05, 2013 at 01:07:16PM +0300, Uri Lublin wrote:
>> In your example, query is "my_param=/some/path" and path points
>> to "/some/path" within query. Some may find it confusing, and it does not
>> follow URI syntax where path comes before query (IIUC).
> This is not meant to move the 'path' part of the URI in the params, but to
> allow the params to contain '/' without confusing SPICE URI parser.
> You can change the example to
> scheme://foo.example.com?mimetype=text/plain
> if that makes things less confusing.

I was wrong saying path may point inside query.

Your patch makes sure path does not point to the middle of query,
since if query ('?') exists, it shortens authority and so path
is being search only between the beginning of authority and query.

And your patch does simplify the code a bit.

Thanks for your patience,
     Uri.


More information about the Spice-devel mailing list