[Spice-devel] bug: inputs_channel_handle_parsed leak of break in switch section

[Hans de Goede]

Hi,

On 06/17/2013 03:47 AM, bigclouds wrote:
> hi,all
> i think  a break is needed.am i right?
> case SPICE_MSGC_INPUTS_KEY_DOWN: {
>          SpiceMsgcKeyDown *key_up = (SpiceMsgcKeyDown *)buf;
>          if (key_up->code == CAPS_LOCK_SCAN_CODE || key_up->code == NUM_LOCK_SCAN_CODE ||
>              key_up->code == SCROLL_LOCK_SCAN_CODE) {
>              activate_modifiers_watch();
>          }
>      }
> break??

No, this is intentional, kbd_push_scan must be called for both up and down events.

Regards,

Hans