[Spice-devel] [spice-gtk] automake: Disable portability warnings

[Daniel P. Berrange]

On Mon, Jun 24, 2013 at 11:27:54AM +0200, Christophe Fergeau wrote:
> -Wportability used to be automatically disabled with automake <= 1.12 when using
> silent rules, but this is no longer the case with automake 1.13 which is what
> fedora 19 uses: http://www.flameeyes.eu/autotools-mythbuster/automake/silent.html
> "As of version 1.13, though, this opt-in is no longer necessary, as all the
> Makefiles are generated to support them. The silent-rules option is now a
> no-op, doing nothing at all, in particular not silencing the portability
> warnings."
> 
> This commit disables these warnings in order to avoid autogen.sh breakage
> because of the use of -Werror, they can be reenabled once gtk-doc.make is
> fixed to avoid these portability warnings.
> ---
>  configure.ac | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 8ab5b6b..bd59ccf 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -7,7 +7,7 @@ AC_CONFIG_MACRO_DIR([m4])
>  AC_CONFIG_HEADER([config.h])
>  AC_CONFIG_AUX_DIR([build-aux])
>  
> -AM_INIT_AUTOMAKE([foreign dist-bzip2 -Wall -Werror])
> +AM_INIT_AUTOMAKE([foreign dist-bzip2 -Wall -Werror -Wno-portability])
>  m4_ifdef([AM_PROG_AR], [AM_PROG_AR])
>  LT_INIT
>  AM_MAINTAINER_MODE

ACK

Use of -Wno-portability is pretty standard practice

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|