[Spice-devel] [PATCH] red_worker: fix for stuck display_channel over WAN (jpeg_enabled=true)

Yonit Halperin yhalperi at redhat.com
Tue Jun 25 11:56:25 PDT 2013


On 06/25/2013 02:50 PM, Marc-André Lureau wrote:
> Hi
>
> ----- Mensaje original -----
>> The image descriptor flags shouldn't be copied as is from the flags that
>> were set by the driver. Specifically, the CACHE_ME flag shouldn't be copied,
>> since it is possible that (a) the image won't be cached (b) the image
>> is already cached, but in its lossy version, and we may want to set the bit
>> for
>> CACHE_REPLACE_ME, in order to cache it in its lossless version.
>> In case (b), the client first looks for the CACHE_ME flag, and only if
>> it is not set it looks for CACHE_REPLACE_ME (see canvas_base.c). Since both
>> flags where set,
>> the client ignored REPLACE_ME, and didn't turned off the lossy flag of the
>> cach item. Then, when a request from this lossles item reached the
>> client (FROM_CACHE_LOSSLESS), the client display channel waited
>> endlessly for the lossless version of the image.
>
> Is there a bug open for this? make sense, ack from me
>
I just opened one: rhbz#977998  (there are other 2 similar bugs, but 
they aren't over WAN...)

Thanks,
Yonit.


More information about the Spice-devel mailing list