[Spice-devel] [PATCH spice-html5] handling cursor caching

[Jeremy White]

Hi Vincent,

On 03/06/2013 04:46 AM, Vincent Desprez wrote:
> A very small patch to handle cursor caching in spice-html. Indeed until
> now the cursor shape wasn't cached so it appeared correctly only once.

Your patch look great, with one exception - you really need
to treat the flags field as a bit mask.  You can see other examples
of how this is done in the code if you search for FLAGS.  So you
shouldn't be comparing flags (e.g. == 1, == 4), but instead defining
a constant and checking a mask (e.g. & SPICE_CURSOR_FLAGS_CACHE_ME).
There are already constants for the cursor flags, so it be pretty easy.

> Independently from that I didn’t see my latest contribution to
> spice-html5 from January 22 in the git repository
> (http://cgit.freedesktop.org/spice/spice-html5/, correct?). Did I
> something wrong?

Ah, I'm sorry, I'm used to Wine style patch submission procedures.

I would prefer that each patch be submitted as a standalone email,
in git-format-patch format, preferably with a subject header of [PATCH]
(and if it's a resubmit, a [PATCH try 2] isn't bad either).

Because you included it in a reply, I didn't realize you
were resubmitting the patch as I had asked.

In fact, this patch is also flawed, and illustrates what I mean.
Take this email (you can download it in raw format from the archives
if you need to), and feed that file into git am.  You'll find that
the commit log is not what you intended.

Actually, I just tried that with this email, and the patch would
not feed into git-am at all; it reports corruption at line 10.  That
is mostly likely a gmail issue:

http://git.661346.n2.nabble.com/How-do-gmail-users-try-out-patches-from-this-list-td3426755.html

The bottom line is that I should be able to download your email to a
file, run git am <the-file-I-downloaded> and get a pleasing result.  You
should be able to fiddle with sending email to yourself until you get
that same result.

Cheers,

Jeremy