[Spice-devel] [spice-devel] [bug] is this a little bug ? (spice-common/common/region.c)

[Hans de Goede]

Hi,

Thanks for catching this!

On 03/07/2013 11:55 AM, zhou link wrote:
> int region_bounds_intersects(const QRegion *rgn1, const QRegion *rgn2)
> {
>      pixman_box32_t *extents1, *extents2;
>
>      extents1 = pixman_region32_extents((pixman_region32_t *)rgn1);
>      extents2 = pixman_region32_extents((pixman_region32_t *)rgn1);            ///////// the rgn1 shoud be rgn2 ?
>
>      return EXTENTCHECK(extents1, extents2);
> }
>
>
> these code also exist in spice-gtk,  is this a  bug ?

Certainly looks like a bug to me. But I'll let others who know the code
better comment on this / review it, before we fix it.

Regards,

Hans