[Spice-devel] [spice-xpi 2/9] Remove unused #include

Christophe Fergeau cfergeau at redhat.com
Thu Mar 7 07:39:28 PST 2013


We include some files from the XUL SDK which gives the impression
that we are depending on some features from them, however they are
actually not used at all, so let's remove them.
---
 SpiceXPI/src/plugin/nsScriptablePeer.cpp     | 1 -
 SpiceXPI/src/plugin/nsScriptablePeerBase.cpp | 1 -
 SpiceXPI/src/plugin/plugin.cpp               | 4 +---
 3 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/SpiceXPI/src/plugin/nsScriptablePeer.cpp b/SpiceXPI/src/plugin/nsScriptablePeer.cpp
index 249e7a3..a09d356 100644
--- a/SpiceXPI/src/plugin/nsScriptablePeer.cpp
+++ b/SpiceXPI/src/plugin/nsScriptablePeer.cpp
@@ -51,7 +51,6 @@
 // be callable from JavaScript
 //
 
-#include <nsError.h>
 #include <string.h>
 #include <sstream>
 #include "plugin.h"
diff --git a/SpiceXPI/src/plugin/nsScriptablePeerBase.cpp b/SpiceXPI/src/plugin/nsScriptablePeerBase.cpp
index eaf3661..cb1e7bd 100644
--- a/SpiceXPI/src/plugin/nsScriptablePeerBase.cpp
+++ b/SpiceXPI/src/plugin/nsScriptablePeerBase.cpp
@@ -39,7 +39,6 @@
  *
  * ***** END LICENSE BLOCK ***** */
 
-#include <nsError.h>
 #include <prtypes.h>
 #include <npapi.h>
 #include <npruntime.h>
diff --git a/SpiceXPI/src/plugin/plugin.cpp b/SpiceXPI/src/plugin/plugin.cpp
index fa04726..24df80b 100644
--- a/SpiceXPI/src/plugin/plugin.cpp
+++ b/SpiceXPI/src/plugin/plugin.cpp
@@ -62,7 +62,6 @@ extern "C" {
 #include <signal.h>
 }
 
-#include "nsCOMPtr.h"
 
 // for plugins
 #ifndef XP_UNIX
@@ -77,9 +76,8 @@ extern "C" {
 static NS_DEFINE_CID(kPluginManagerCID, NS_PLUGINMANAGER_CID);
 #endif
 
-#include <nsIServiceManager.h>
-#include <nsISupportsUtils.h> // some usefule macros are defined here
 
+#include <cstring>
 #include <fstream>
 #include <set>
 
-- 
1.8.1.4



More information about the Spice-devel mailing list