[Spice-devel] [PATCH spice-gtk 06/15] channel-main: Drop bogus xfer_id check from file_xfer_send_start_msg_async

Hans de Goede hdegoede at redhat.com
Sat Mar 9 03:06:26 PST 2013


xfer_id > UINT32_MAX is never true since xfer_id is an uint32_t, and
thus explicit wrapping is not necessary since it will wrap every
UINT32_MAX + 1 itereations anyways.

Signed-off-by: Hans de Goede <hdegoede at redhat.com>
---
 gtk/channel-main.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/gtk/channel-main.c b/gtk/channel-main.c
index 06546d1..e7c8ef3 100644
--- a/gtk/channel-main.c
+++ b/gtk/channel-main.c
@@ -2671,8 +2671,6 @@ static void file_xfer_send_start_msg_async(SpiceMainChannel *channel,
     SpiceFileXferTask *task;
     static uint32_t xfer_id;    /* Used to identify task id */
 
-    xfer_id = (xfer_id > UINT32_MAX) ? 0 : xfer_id;
-
     task = spice_malloc0(sizeof(SpiceFileXferTask));
     task->id = ++xfer_id;
     task->channel = channel;
-- 
1.8.1.4



More information about the Spice-devel mailing list