[Spice-devel] [PATCH spice-gtk 03/15] spice-widget: fix file drag-n-drop mime-type

[Dunrong Huang]

Hi,

On Sat, Mar 9, 2013 at 11:23 PM, Hans de Goede <hdegoede at redhat.com> wrote:
> Hi,
>
>
> On 03/09/2013 04:08 PM, Dunrong Huang wrote:
>>
>> On Sat, Mar 9, 2013 at 7:06 PM, Hans de Goede <hdegoede at redhat.com> wrote:
>>>
>>> Currently the user can drag-drop text onto the widget, and it will try to
>>> open it as a file, not good, this fixes this.
>>>
>>> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
>>> ---
>>>   gtk/spice-widget.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/gtk/spice-widget.c b/gtk/spice-widget.c
>>> index 42d0cdd..e4c64ee 100644
>>> --- a/gtk/spice-widget.c
>>> +++ b/gtk/spice-widget.c
>>> @@ -536,7 +536,7 @@ static void spice_display_init(SpiceDisplay *display)
>>>   {
>>>       GtkWidget *widget = GTK_WIDGET(display);
>>>       SpiceDisplayPrivate *d;
>>> -    GtkTargetEntry targets = {"text/plain", 0, 0};
>>> +    GtkTargetEntry targets = { "text/uri-list", 0, 0 };
>>>
>> The file from some file managers(e.g. thunar) can't be dragged to
>> spice widget in previous version. This patch really fixes it.
>>
>> Tested-by: ...
>
>
> Good to hear!
>
> BTW not sure if I responded to the agent patch-series, but I've merged them
> upstream as well as added some bugfixes on top.
>
Thank you for your merging.
> Now all we need is for someone to add support to the windows
> agent (hint hint).
And we can then implement other features, e.g. progress bar, support
for transfer directory, and so on. :)
>
> Regards,
>
> Hans



-- 
Best Regards,

Dunrong Huang