[Spice-devel] [spice-xpi 10/12] Add helper function to get client paths

[Marc-André Lureau]

On Tue, Mar 12, 2013 at 12:23 PM, Christophe Fergeau
<cfergeau at redhat.com> wrote:
> void SpiceController::GetClientPaths(GStrv *client_argv, GStrv *fallback_argv)
> +{
> +    if (client_argv != NULL) {
> +        *client_argv = g_new0(char *, 2);
> +        (*client_argv)[0] = g_strdup("/usr/libexec/spice-xpi-client");
> +    }
> +
> +    if (fallback_argv != NULL) {
> +        *client_argv = g_new0(char *, 3);
> +        (*client_argv)[0] = g_strdup("/usr/bin/spicec");
> +        (*client_argv)[1] = g_strdup("--controller");
> +    }
> +}

any reason this needs to be allocated? I would rather see a static const array.

Also, I don't see why it should be returned by the same function.




-- 
Marc-André Lureau