[Spice-devel] [xf86-video-qxl warnings 3/6] Document a meaningful warning.

Jeremy White jwhite at codeweavers.com
Thu Mar 21 09:23:10 PDT 2013


Signed-off-by: Jeremy White <jwhite at codeweavers.com>
---
 src/qxl_ring.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/qxl_ring.c b/src/qxl_ring.c
index 2156113..0dcacf7 100644
--- a/src/qxl_ring.c
+++ b/src/qxl_ring.c
@@ -91,6 +91,8 @@ qxl_ring_push (struct qxl_ring *ring,
     idx = header->prod & (ring->n_elements - 1);
     elt = ring->ring->elements + idx * ring->element_size;
 
+    /* TODO:  We should use proper MMIO accessors; the use of
+             volatile leads to a gcc warning.  See commit f7ba4bae */
     memcpy((void *)elt, new_elt, ring->element_size);
 
     header->prod++;
-- 
1.7.10.4





More information about the Spice-devel mailing list