[Spice-devel] [xf86-video-qxl warnings 5/6] Actually request the forcibly inline functions to be inline.

[Christophe Fergeau]

On Thu, Mar 21, 2013 at 12:56:33PM -0500, Jeremy White wrote:
> > Hi,
> > 
> > So gcc is not happy with the FORCE_INLINE  which translates into  
> > "__attribute__((always_inline)"
> > and requires an additional "inline" ?
> 
> Google led me to this similar commit for DragonFly BSD:
> 
>   http://leaf.dragonflybsd.org/mailarchive/commits/2012-10/msg00145.html
> 
> It says:
> 
> > The '__attribute__((always_inline))' does not strictly imply 'inline'.
> >     Newer versions of gcc detect this misuse and issue the warning.
> >     Including the missing 'inline' resolves the build warning.
> 
> Looked reasonable to me, hence the patch.

I'd expect gcc to inline the function anyway, even without 'inline FORCE_INLINE'

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20130322/245573d1/attachment.pgp>