[Spice-devel] [spice-xpi 5/5] Add glib Windows logging

Marc-André Lureau mlureau at redhat.com
Mon Mar 25 05:07:34 PDT 2013



----- Mensaje original -----
> On Mon, Mar 25, 2013 at 12:18:32PM +0100, Marc-André Lureau wrote:
> > On Mon, Mar 25, 2013 at 11:50 AM, Christophe Fergeau
> > <cfergeau at redhat.com> wrote:
> > > I've considered that, but this means I'd have to sanitize the
> > > filename for
> > > \, '..', and probably some other things I didn't think of. As
> > > this is just
> > > a debugging help, I've chosen to go with a hardcoded filename
> > > which does
> > > not need additional care. I can change that if you feel strongly
> > > about it.
> > 
> > Imho, there is no need for that. If the user provide a wrong
> > filename,
> > it should fail.
> 
> Well, setting it to ..\..\..\bootmgr could lead to interesting
> results, and
> I'd like to protect against such issues if I add support for an
> arbitrary
> filename.

This is clearly not your responsibility at this point. This is the job of the OS.


More information about the Spice-devel mailing list