[Spice-devel] [spice-gtk PATCH 0/9] Windows: identify USB devices by vid:pid instead of bus.address

Uri Lublin uril at redhat.com
Wed Mar 27 11:34:42 PDT 2013


On 03/27/2013 06:49 PM, Hans de Goede wrote:
> Hi,
>
> As discussed as a solution for this *for now*, this series looks good, 
> ACK series.
>
> One remark, which can be fixed with an add on patch, or added to patch 9,
> around line 734 (in unpatches sources), in 
> spice_usb_device_manager_add_dev,
> there is:
>
>     if (!device) {
>         g_warning("Could not find USB device to add at busnum %d 
> devaddr %d",
>                   bus, address);
>         return;
>     }
>
> This should be modified to use DEV_ID_FMT too.

Yes, I'll add it.

Thanks,
     Uri.



More information about the Spice-devel mailing list