[Spice-devel] [PATCH 2/9] server/red_worker: turn critical (assert) non error into warning

Alon Levy alevy at redhat.com
Fri May 17 08:08:07 PDT 2013


The situation causing this assert is unknown but it doesn't cause
correctness issues with later rendering, and it is causing an abort.
---
 server/red_worker.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/server/red_worker.c b/server/red_worker.c
index 8f3e478..14d219b 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@@ -11367,7 +11367,10 @@ static void red_push_monitors_config(DisplayChannelClient *dcc)
 {
     MonitorsConfig *monitors_config = DCC_TO_WORKER(dcc)->monitors_config;
 
-    spice_return_if_fail(monitors_config != NULL);
+    if (monitors_config == NULL) {
+        spice_warning("monitors_config is NULL");
+        return;
+    }
 
     if (!red_channel_client_test_remote_cap(&dcc->common.base,
                                             SPICE_DISPLAY_CAP_MONITORS_CONFIG)) {
-- 
1.8.2.1



More information about the Spice-devel mailing list