[Spice-devel] [PATCH spice-gtk] widget: release keys on grab-broken

[Hans de Goede]

ACK.

BTW didn't we've a fixme comment for this somewhere, which then can
be removed (preferably squashed into this commit), or was that
only in a commit msg?

Regards,

Hans


On 05/23/2013 01:56 AM, Marc-André Lureau wrote:
> This is similar to 8cbd5d745c221f788878c9c713f3b46a25828d3f and can be
> reproduced by pressing Win+l while the widget has the keyboard
> grab (pointer over the display).
>
> I have not reproduced implicit grab-broken event, I suppose they could
> happen if the grab is stolen from within the app. In any case, it's
> probably better to release the keys.
>
> This is related to:
> https://bugzilla.redhat.com/show_bug.cgi?id=917986
> ---
>   gtk/spice-widget.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/gtk/spice-widget.c b/gtk/spice-widget.c
> index 4f74380..c05b600 100644
> --- a/gtk/spice-widget.c
> +++ b/gtk/spice-widget.c
> @@ -482,6 +482,7 @@ static gboolean grab_broken(SpiceDisplay *self, GdkEventGrabBroken *event,
>
>       if (event->keyboard) {
>           try_keyboard_ungrab(self);
> +        release_keys(self);
>       }
>
>       /* always release mouse when grab broken, this could be more
>