[Spice-devel] [spice sound rework 2/3 (take 3)] Revise the spice client and server to use the new snd_codec functions in spice-common.

Jeremy White jwhite at codeweavers.com
Mon Nov 4 19:48:13 CET 2013


On 11/04/2013 10:17 AM, Christophe Fergeau wrote:
> On Thu, Oct 31, 2013 at 11:09:37AM -0500, Jeremy White wrote:
>> @@ -1572,18 +1541,16 @@ void snd_set_playback_compression(int
>> on) { SndWorker *now = workers;
>> 
>> -    playback_compression = on ? SPICE_AUDIO_DATA_MODE_CELT_0_5_1
>> : SPICE_AUDIO_DATA_MODE_RAW; +    playback_compression = on;
> 
> Nit, I'dnormalize the value here: playback_compression = !!on;

Sure.  Patch resent.

> 
> ACK series! (only had a quick look at the parts that were changed,
> not at the whole series again). Next, Opus.

Great, thanks!  Note that I don't have commit authority on those trees
(which is just fine with me <evil grin>), so I'll need someones help
getting them applied.

Cheers,

Jeremy


More information about the Spice-devel mailing list