[Spice-devel] [PATCH 2/2] vdagent: add max-clipboard message

[Marc-André Lureau]

On Thu, Nov 7, 2013 at 11:37 PM, Marc-André Lureau
<marcandre.lureau at gmail.com> wrote:
> On Thu, Nov 7, 2013 at 11:17 PM, Uri Lublin <uril at redhat.com> wrote:
>> On 11/06/2013 10:07 PM, Marc-André Lureau wrote:
>>>
>>> Add an optional message sent by the client to ask the agent not to send
>>> clipboard data bigger than a certain size, in bytes.  The message can be
>>> sent if the agent supports the capability MAX_CLIPBOARD, at any time.
>>>
>>> The agent is free to ignore or forget the value after a restart or a
>>> disconnection, but a bigger message might be discarded when received on
>>> client side, resulting in bandwidth waste.
>>
>>
>> Hi Marc-Andre,
>>
>> Maybe better if they negotiate that size -- each report its supported max
>> and
>> the min max is picked.
>
> I don't think that make so much sense.
>
> If the client crash for OOM reason (which it shouldn't afaik, it is

sorry, the agent

> quite OOM-safe), it should be restarted automatically anyway.
>
> Furthermore, I think it's better if the client has full control over
> the setting, and not be limited by guest configuration which he could
> change.
>
> If really this is necessary for some obscure reason that I don't
> forsee, I'd  see that as a future protocol capability.
>
>> I'd expect that after e.g. a disconnection, this value is to be negotiated
>> again
>> as part of connection.
>>
>> Thanks,
>>     Uri.
>
>
>
> --
> Marc-André Lureau



-- 
Marc-André Lureau