[Spice-devel] [vdagent-win PATCH 6/6] Makefile.am: add INCLUDES to AM_CPPFLAGS

Christophe Fergeau cfergeau at redhat.com
Fri Nov 8 05:05:42 PST 2013


On Fri, Nov 08, 2013 at 12:02:56AM +0200, Uri Lublin wrote:
> Fixes the following autoreconf (automake) warning:
> Makefile.am:6: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
> 
> diff --git a/Makefile.am b/Makefile.am
> index da0b5a5..fc017d5 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -3,13 +3,13 @@ MAINTAINERCLEANFILES =
> 
>  DIST_SUBDIRS = spice-protocol
> 
> -INCLUDES =				\
> +INC =					\
>  	-I$(top_srcdir)/common		\
>  	-I$(top_srcdir)/spice-protocol	\
>  	$(NULL)
> 
>  AM_CXXFLAGS = -flto -fwhole-program
> -AM_CPPFLAGS = -DUNICODE -D_UNICODE -DOLDMSVCRT
> +AM_CPPFLAGS = -DUNICODE -D_UNICODE -DOLDMSVCRT $(INC)

Can you make that one
AM_CPPFLAGS =				\
	-DUNICODE			\
	-D_UNICODE			\
	-DOLDMSVCRT			\
	-I$(top_srcdir)/common		\
	-I$(top_srcdir)/spice-protocol	\
	$(NULL)
and remove INCLUDES/INC?
Imo it's easier to read

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20131108/f0ba57af/attachment-0001.pgp>


More information about the Spice-devel mailing list