[Spice-devel] [spice-common RFC] Introduce SPICE_COMMON_SETUP m4 macro

[Christophe Fergeau]

On Fri, Nov 08, 2013 at 04:10:16PM -0500, Marc-André Lureau wrote:
> 
> 
> ----- Original Message -----
> > This macro gathers the various checks/substitutions that spice-common's
> > configure.ac needs to do. It's meant to be called by users of the
> > spice-common submodule instead of calling AC_CONFIG_SUBDIRS() which is
> > much slower and less flexible.
> 
> Speed? It takes less than 10s on my machine at configure time. benefit is
> really marginal.

Good that you have a SSD, it takes 30 seconds here every time I run
autogen.sh in spice/ or spice-gtk/, and most of these 30 seconds is
duplicating work that has already been done in the toplevel configure.ac

> But more, that goes in the wrong direction. The idea was
> and is till to have a shared library. But for that to happen, somebody
> needs to clean up API, and version it etc..

The devil is in that etc.., there is still this automagic code generation
in the server/client code with inclusion of .c files and different
#defines, so it's more involved than an API clean up. And it will also take
much more time.


> I would rather take this change happily than some awkward build change.

This shared library configure.ac could also use that macro, so we don't
lose much by introducing it, it can also be just copied and pasted back to
configure.ac the day there is such a shared library. This library did
not get closer in the 18 months we have been using submodules, so I would
not hold my breath for it to appear now ;)

Until this happens, using this macro will save every developer's time, and
avoid some awkward weirdness in spice/ and spice-gtk/ builds (is config.h
or spice-common/config.h used when compiling the various files,
useless check for opus/celt in the main configure.ac just to be able to
have an accurate Requires.private line in the .pc file, warnings used in
the toplevel build and in spice-common do not seem to be consistent, ...)

I'll happily redo a configure.ac/fix make distcheck/... when we want to
turn this into a standalone module.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20131109/2ecf5c03/attachment.pgp>