[Spice-devel] [PATCH usbclerk] Fix possibly missing files after upgrade

Marc-André Lureau marcandre.lureau at gmail.com
Fri Nov 8 17:34:22 PST 2013


From: Marc-André Lureau <marcandre.lureau at gmail.com>

This is similar to the fix for virt-viewer:
https://www.redhat.com/archives/virt-tools-list/2013-November/msg00030.html

Although it's not mandatory for simple cases,
RemoveExistingProducts should be Schedule='afterInstallFinalize', see
also:

http://msdn.microsoft.com/en-us/library/aa371197%28v=vs.85%29.aspx
http://stackoverflow.com/questions/15138731/wix-major-upgrade-not-installing-all-files
---
 usbclerk.wxs.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/usbclerk.wxs.in b/usbclerk.wxs.in
index 8cb918a..93fb192 100644
--- a/usbclerk.wxs.in
+++ b/usbclerk.wxs.in
@@ -32,7 +32,7 @@
     </Upgrade>
     <Condition Message="USB Clerk is already installed.">NOT NEWERVERSIONDETECTED</Condition>
     <InstallExecuteSequence>
-      <RemoveExistingProducts After="InstallValidate"/>
+      <RemoveExistingProducts After="InstallFinalize"/>
     </InstallExecuteSequence>
 
     <!-- try to uninstall NSIS -->
-- 
1.8.3.1



More information about the Spice-devel mailing list