[Spice-devel] [spice-common RFC] Introduce SPICE_COMMON_SETUP m4 macro

[Christophe Fergeau]

On Fri, Nov 08, 2013 at 08:02:39PM -0500, Marc-André Lureau wrote:
> > Good that you have a SSD, it takes 30 seconds here every time I run
> > autogen.sh in spice/ or spice-gtk/, and most of these 30 seconds is
> > duplicating work that has already been done in the toplevel configure.ac
> 
> If you autogen every day, you are doing it wrong. And 2x30s or 1x30s for
> something you do once in a while as a developer, that's really not that
> important.

Every time configure.ac changes (for example because you switched
branches), things get autoreconf'ed/configure reruns. And I'll keep using
git branches, thank you.

> > This shared library configure.ac could also use that macro, so we don't
> > lose much by introducing it, it can also be just copied and pasted back to
> > configure.ac the day there is such a shared library. This library did
> > not get closer in the 18 months we have been using submodules, so I would
> > not hold my breath for it to appear now ;)
> 
> It is easy today to start improving things, as you can build the
> submodule independently, like a regular project.

Ok, point taken, it shouldn't be too hard to keep configure.ac and have it
use the macro...

> we had a clean configure.ac and you turn this into a horrible .m4 for bad
> reasons. Readability is more important here.

Let's not start on 'readibility' as the configure.ac has issues of its own
loosely related to that which I mentioned in the paragraph quoted below.

> 
> > Until this happens, using this macro will save every developer's time, and
> > avoid some awkward weirdness in spice/ and spice-gtk/ builds (is config.h
> > or spice-common/config.h used when compiling the various files,
> > useless check for opus/celt in the main configure.ac just to be able to
> > have an accurate Requires.private line in the .pc file, warnings used in
> > the toplevel build and in spice-common do not seem to be consistent, ...)
> > 
> > I'll happily redo a configure.ac/fix make distcheck/... when we want to
> > turn this into a standalone module.
> 
> I would prefer to save 1kb/s of bandwidth or 0.1% cpu rather than
> spending our time fighting 30s of autofoo...

Well, I spent _my_ time improving _my_ workflow, and it's mostly done now.
You seem to have missed the other technical issues I have pointed out (ie
how it makes things harder to maintain and more confusing).

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20131112/04d6752e/attachment.pgp>