[Spice-devel] [vdagent-win v2 PATCH 0/6] file_xfer fixes and some cleanups

Marc-André Lureau marcandre.lureau at gmail.com
Wed Nov 13 04:29:19 PST 2013


This patch series doesn't apply upstream
(git.freedesktop.org/git/spice/win32/vd_agent)

On Wed, Nov 13, 2013 at 11:21 AM, Christophe Fergeau
<cfergeau at redhat.com> wrote:
> ACK series
>
> Christophe
>
> On Wed, Nov 13, 2013 at 11:22:27AM +0200, Uri Lublin wrote:
>> The destination directory for file_xfer was a public one (e.g. desktop
>> directory of all-users). This is since vdagent.exe does not run as
>> current logged in user.
>>
>> This patch-set makes the creation of the file run as the logged in user,
>> such that the destination directory for file-xfer is the user's
>> desktop directory. Plus some cleanups.
>>
>> v1->v2:
>>   patch1: as_user destructor calls end() unconditionally.
>>   patch3 and patch 4 are swapped
>>   patch6: INC is removed -- INCLUDES added directly to AM_CPPFLAGS.
>>
>>
>> Uri Lublin (6):
>>   vdagent: add as_user to run tasks with user privileges
>>   file_xfer: create file with user privileges
>>   vdagent: file-xfer: make user desktop the target directory
>>   vdagent: file_xfer: make g_key_get_string safer
>>   Makefile.am: tabify
>>   Makefile.am: add INCLUDES to AM_CPPFLAGS
>>
>>  Makefile.am            | 14 ++++++----
>>  vdagent/as_user.cpp    | 73 ++++++++++++++++++++++++++++++++++++++++++++++++++
>>  vdagent/as_user.h      | 38 ++++++++++++++++++++++++++
>>  vdagent/file_xfer.cpp  | 34 ++++++++++++++++++-----
>>  vdagent/file_xfer.h    |  3 ++-
>>  vdagent/vdagent.vcproj |  8 ++++++
>>  6 files changed, 157 insertions(+), 13 deletions(-)
>>  create mode 100644 vdagent/as_user.cpp
>>  create mode 100644 vdagent/as_user.h
>>
>> --
>> 1.8.3.1
>>
>> _______________________________________________
>> Spice-devel mailing list
>> Spice-devel at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>



-- 
Marc-André Lureau


More information about the Spice-devel mailing list